Forums

The proposed changes look fine ... except for maybe a minor point or two:

>
> 1) setXXX/addXXX functions will all change their return type from
> void
> to unsigned int.
>
> The code within the function will perform checks to establish whether
> performing the function is valid.
>
> If it is valid the set/add will be done and 0 returned.
>

I was wondering is there any particular reason to choose unsigned ints?
(Apart from 'there is a lot more of them'). My reasoning is that in most
projects I find negative numbers used for bad things, thus maintaining the
possibility to re-use positive numbers for something useful (like an insert
function returning the index of where to find the object after insertion).

>
> 2) The setLevelAndVersion function on a document is currently an
> anomaly
> since it does return a bool based on whether the conversion has been
> performed. Changing the return type of this function will allow more
> constructive failure information to be returned, however it may have
> more of an impact on existing code.
>
> QUESTION: Do we make this change ??

I don't think the change is necessary, even now a failed conversion
gives us plenty of information when conversion fails as in:

line 1: (90001 [Error]) Use of SBML Level 1 Version 1 is not recommended and
conversion is not supported by libSBML.

line 8: (91001 [Error]) A model with <event> definitions cannot be
represented in SBML Level 1.



>
> Release of new API
> ===============
>
...
>
> QUESTION: Does anyone have a major problem with this ?
>

No problem here ...

> Thanks for your input
>
> Sarah, Akiya & Mike
>
> ____________________________________________________________
> To manage your libsbml-development list subscription, visit
> https://utils.its.caltech.edu/mailman/listinfo/libsbml-development
>
> For a web interface to the libsbml-development mailing list, visit
> http://sbml.org/Forums/
>
> For questions or feedback about the libsbml-development list,
> contact sbml-team@caltech.edu


____________________________________________________________
To manage your libsbml-development list subscription, visit
https://utils.its.caltech.edu/mailman/listinfo/libsbml-development

For a web interface to the libsbml-development mailing list, visit
http://sbml.org/Forums/

For questions or feedback about the libsbml-development list,
contact sbml-team@caltech.edu