Posts: 307
Location: Cambridge UK
Registered: February 2005
Re: Problems found so far
30 Nov '10 01:55
On 11/30/2010 09:28 AM, Sarah Keating wrote:
> Hi Guys
>
>> * getDerivedUnitDefinition() is not working properly if there is not
>> unit defined.
>> see
>> http://sbml.svn.sourceforge.net/viewvc/sbml/trunk/libsbml/src/units/UnitFormulaFormatter.cpp?revision=12199&view=markup
>> see
>> http://sbml.svn.sourceforge.net/viewvc/sbml/trunk/libsbml/src/sbml/Model.cpp?revision=12199&view=markup
>>
>> In Model.cpp, see the method populateListFormulaUnitsData
>> Seems to be a lot of work not going to be part of the first release
>> for sure and may be one of the functionality to get via webservices ?
>
> Just a note on this. The populateListFormulaUnitsData function is only
> necessary if you either
>
> 1) use unit consistency checking - which if you are doing this by
> webservice is not necessary
>
> or
>
> 2) use the getDerivedUnitDefinition functions.
>
> If the populateList... function is not working fully then you cannot
> guarantee that the getDerivedUnitDefinition functions are either. You
> might need to consider the options on this. You could do a release
> without the getDerivedUnitDefinition functions and see how many people
> want them.
>
We have no populateListFormulaUnitsData at all in fact. We have the
getDerivedUnitDefinition
but they are just creating a unitDefinition if a unit was define on the
element.
> You are right having the unit stuff as a web service might not be a bad
> idea overall anyway.
>
yes, at least, we should postpone it for later and evaluate the
different possibilities and their performance.
We should find a way where you don't have to pass along the whole model
each time your are calling the getDerivedUnitDefinition !!
| 
30 Nov '10 01:55
