Forums

Am 4/24/12 12:14 PM, schrieb Nicolas Rodriguez:
> Not a big deal but sometime, you have classes that do not have id so may
> be we could have two constructor templates ?
>
> Also, in writeXMLAttributes, you don't need to do
>
> // attributes.remove("validationXMLAllchecks");
>
> for each attribute, only for the attribute that are already present in
> the extended core classes.
> So only for id and name in fact. We could do an AbstractExtNamedSBase
> that would implement only the
> writeXMLAttributes for id and name so that we don't need to do that on
> every NamedSBase in the extensions.
>
> It is still on my todo list to update the user guide about these
> read/write XML attributes methods btw, I haven't forgotten :-)
>
>

Hi,

Maybe it won't always be possible to extend AbstractExtNamedSBase in
extension packages because the specifications sometimes may define an
inheritance structure that might require a different inheritance
relationship. But I agree, if possible we should use such a class.

By the way, some time ago I also proposed another change. Here is my
previous text:

I would like to ask why we decided that the interface
SBasePlugin does not extend the interface TreeNodeWithChangeSupport and
why the abstract class AbstractSBasePlugin does not extend
AbstractTreeNode. I understand that extensions to some SBase are not a
separate TreeNode, but since the getChildAt(int) method simply excludes
extension elements anyway (but not their children), we could avoid a
duplication of code by making AbstractSBasePlugin a derivative of
AbstractTreeNode (all other methods seem to be simimilar).

In this way, it would also become possible to maintain userObjects
within instances of SBasePlugin, which is not possible at the moment (it
would again require a duplication of code).


Cheers
Andreas

--
Dr. Andreas Dräger
University of Tuebingen
Center for Bioinformatics Tuebingen (ZBIT)
Sand 1
72076 Tübingen
Germany

Phone: +49-7071-29-78982
Fax: +49-7071-29-5091

____________________________________________________________
To manage your jsbml-development list subscription, visit
https://utils.its.caltech.edu/mailman/listinfo/jsbml-development

For a web interface to the jsbml-development mailing list, visit
http://sbml.org/Forums/

For questions or feedback about the jsbml-development list,
contact sbml-team@caltech.edu